Re: [PATCH v3] infiniband: i40iw: fix a potential NULL pointer dereference

From: Leon Romanovsky
Date: Thu Dec 26 2019 - 09:40:14 EST


On Thu, Dec 26, 2019 at 09:21:56PM +0800, xiyuyang19@xxxxxxxxxxxx wrote:
> From: Xiyu Yang <xiyuyang19@xxxxxxxxxxxx>
>
> in_dev_get may return a NULL object. The fix handles the situation
> by adding a check to avoid NULL pointer dereference on idev,
> as pick_local_ipaddrs does.
>
> Signed-off-by: Xiyu Yang <xiyuyang19@xxxxxxxxxxxx>
> Signed-off-by: Xin Tan <tanxin.ctf@xxxxxxxxx>
> ---
> Changes in v2:
> - Release rtnl lock when in_dev_get return NULL
> Changes in v3:
> - Continue the next loop when in_dev_get return NULL
>
> drivers/infiniband/hw/i40iw/i40iw_main.c | 2 ++
> 1 file changed, 2 insertions(+)
>

Thanks,
Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>