RE: [EXT] Re: [net-next] enetc: add support time specific departure base on the qos etf

[Po Liu]

Br,
Po Liu

> -----Original Message-----
> From: David Miller <davem@xxxxxxxxxxxxx>
> Sent: 2019年12月27日 7:10
> To: Po Liu <po.liu@xxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx;
> vinicius.gomes@xxxxxxxxx; Claudiu Manoil <claudiu.manoil@xxxxxxx>;
> Vladimir Oltean <vladimir.oltean@xxxxxxx>; Alexandru Marginean
> <alexandru.marginean@xxxxxxx>; Xiaoliang Yang
> <xiaoliang.yang_1@xxxxxxx>; Roy Zang <roy.zang@xxxxxxx>; Mingkai Hu
> <mingkai.hu@xxxxxxx>; Jerry Huang <jerry.huang@xxxxxxx>; Leo Li
> <leoyang.li@xxxxxxx>; ivan.khoronzhuk@xxxxxxxxxx
> Subject: [EXT] Re: [net-next] enetc: add support time specific departure base on
> the qos etf
> 
> Caution: EXT Email
> 
> From: Po Liu <po.liu@xxxxxxx>
> Date: Mon, 23 Dec 2019 03:42:39 +0000
> 
> > - Transmit checksum offloads and time specific departure operation are
> > mutually exclusive.
> 
> I do not see anything which enforces this conflict.
> 
> It looks to me like if the user configures time specific departure, and TX SKBs will
> be checksum offloaded, the time specific departure will simply not be performed.
> 
> If true, this behavior will be very surprising for the user.
> 
> Instead, the configuration operation that creates the conflict should throw and
> error and fail.

I would fix it.

> 
> Thank you.