Re: [PATCH -next] fbdev: omapfb: use devm_platform_ioremap_resource() to simplify code

From: Bartlomiej Zolnierkiewicz
Date: Fri Jan 03 2020 - 07:14:13 EST



On 9/4/19 1:54 PM, YueHaibing wrote:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>

Thanks, patch queued for v5.6 (also sorry for the delay).

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> ---
> drivers/video/fbdev/omap2/omapfb/vrfb.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/video/fbdev/omap2/omapfb/vrfb.c b/drivers/video/fbdev/omap2/omapfb/vrfb.c
> index 819e0bc..ee0dd4c 100644
> --- a/drivers/video/fbdev/omap2/omapfb/vrfb.c
> +++ b/drivers/video/fbdev/omap2/omapfb/vrfb.c
> @@ -339,9 +339,7 @@ static int __init vrfb_probe(struct platform_device *pdev)
> int i;
>
> /* first resource is the register res, the rest are vrfb contexts */
> -
> - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - vrfb_base = devm_ioremap_resource(&pdev->dev, mem);
> + vrfb_base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(vrfb_base))
> return PTR_ERR(vrfb_base);
>