[PATCH INTERNAL v2] firmware: tee_bnxt: Fix multiple call to tee_client_close_context

From: Vikas Gupta
Date: Fri Jan 03 2020 - 11:22:23 EST


Fix calling multiple tee_client_close_context in case of shm allocation
fails.

Fixes: 246880958ac9 (âfirmware: broadcom: add OP-TEE based BNXT f/w managerâ)
Signed-off-by: Vikas Gupta <vikas.gupta@xxxxxxxxxxxx>
---
drivers/firmware/broadcom/tee_bnxt_fw.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c
index 5b7ef89..ed10da5 100644
--- a/drivers/firmware/broadcom/tee_bnxt_fw.c
+++ b/drivers/firmware/broadcom/tee_bnxt_fw.c
@@ -215,7 +215,6 @@ static int tee_bnxt_fw_probe(struct device *dev)
fw_shm_pool = tee_shm_alloc(pvt_data.ctx, MAX_SHM_MEM_SZ,
TEE_SHM_MAPPED | TEE_SHM_DMA_BUF);
if (IS_ERR(fw_shm_pool)) {
- tee_client_close_context(pvt_data.ctx);
dev_err(pvt_data.dev, "tee_shm_alloc failed\n");
err = PTR_ERR(fw_shm_pool);
goto out_sess;
--
2.7.4