Re: [PATCH 1/2] dt-bindings: display: panel: Add AUO B116XAK01 panel bindings

[Sam Ravnborg]

Hi Rob.

On Fri, Jan 03, 2020 at 10:30:23AM -0800, Rob Clark wrote:
> From: Rob Clark <robdclark@xxxxxxxxxxxx>
> 
> Signed-off-by: Rob Clark <robdclark@xxxxxxxxxxxx>
> ---
>  .../bindings/display/panel/auo,b116xa01.yaml  | 32 +++++++++++++++++++
>  1 file changed, 32 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/auo,b116xa01.yaml
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/auo,b116xa01.yaml b/Documentation/devicetree/bindings/display/panel/auo,b116xa01.yaml
> new file mode 100644
> index 000000000000..6cb8ed9b2c0a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/auo,b116xa01.yaml
> @@ -0,0 +1,32 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/auo,b116xa01.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: AUO B116XAK01 eDP TFT LCD Panel
> +
> +allOf:
> +  - $ref: panel-common.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - auo,b116xa01
> +  port: true
Add an empty line before listing the other properties.

> +
> +required:
> +  - compatible
The panel needs power - so power-supply is required too.

> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    panel {
> +        compatible = "auo,b116xa01";
> +        port {
> +            panel_in: endpoint {
> +                remote-endpoint = <&edp_out>;
> +            };
> +        };
> +    };
For simple panels the example is more or less noise.
We are discusing to move all binding info to a few files for the simple
(dumb) panels.
This is a candidate for this as well.

But there is not yet a conclusion.

	Sam