Re: [PATCH] net: 3com: 3c59x: remove set but not used variable 'mii_reg1'

From: tedheadster
Date: Fri Jan 03 2020 - 15:03:33 EST


On Fri, Jan 3, 2020 at 2:40 PM Andrew Lunn <andrew@xxxxxxx> wrote:
>
> > And since more reviewers are on the same boat, the fix should probably
> > look to eliminate the warning by doing something like:
> >
> > (void)mdio_read(dev, vp->phys[0], MII_BMSR);
>
> Yes, this is the safe option.


I have actual hardware I can test the proposed patches on, if desired.

- Matthew Whitehead