Re: [PATCH v2 1/8] dt-bindings: remoteproc: Add Qualcomm PIL info binding

From: Rob Herring
Date: Sat Jan 04 2020 - 16:38:10 EST


On Thu, Dec 26, 2019 at 09:32:08PM -0800, Bjorn Andersson wrote:
> Add a devicetree binding for the Qualcomm periperal image loader
> relocation info region found in the IMEM.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> ---
>
> Changes since v1:
> - New patch
>
> .../bindings/remoteproc/qcom,pil-info.yaml | 35 +++++++++++++++++++
> 1 file changed, 35 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,pil-info.yaml
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,pil-info.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,pil-info.yaml
> new file mode 100644
> index 000000000000..715945c683ed
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,pil-info.yaml
> @@ -0,0 +1,35 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/remoteproc/qcom,pil-info.yaml#";
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#";
> +
> +title: Qualcomm peripheral image loader relocation info binding
> +
> +description:
> + This document defines the binding for describing the Qualcomm peripheral
> + image loader relocation memory region, in IMEM, which is used for post mortem
> + debugging of remoteprocs.
> +
> +maintainers:
> + - Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> +
> +properties:
> + compatible:
> + const: qcom,pil-reloc-info
> +
> + offset:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: Offset in the register map for the memory region

Why not use 'reg' instead?

> +
> +examples:
> + - |
> + imem@146bf000 {
> + compatible = "syscon", "simple-mfd";
> + reg = <0 0x146bf000 0 0x1000>;
> +
> + pil-reloc {
> + compatible ="qcom,pil-reloc-info";
> + offset = <0x94c>;
> + };
> + };
> --
> 2.24.0
>