Re: [PATCH 2/2] habanalabs: do not halt Coresight during hard reset

[Oded Gabbay]

On Sun, Jan 5, 2020 at 11:05 AM Omer Shpigelman <oshpigelman@xxxxxxxxx> wrote:
>
> During hard reset we must not write to the device.
> Hence avoid halting Coresight during user context close if it is done
> during hard reset.
> In addition, we must not reenable clock gating afterwards as it was
> deliberately disabled in the beginning of the hard reset flow.
>
> Signed-off-by: Omer Shpigelman <oshpigelman@xxxxxxxxx>
> ---
>  drivers/misc/habanalabs/device.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/misc/habanalabs/device.c b/drivers/misc/habanalabs/device.c
> index 166883b64725..b680b0caa69b 100644
> --- a/drivers/misc/habanalabs/device.c
> +++ b/drivers/misc/habanalabs/device.c
> @@ -598,7 +598,9 @@ int hl_device_set_debug_mode(struct hl_device *hdev, bool enable)
>                         goto out;
>                 }
>
> -               hdev->asic_funcs->halt_coresight(hdev);
> +               if (!hdev->hard_reset_pending)
> +                       hdev->asic_funcs->halt_coresight(hdev);
> +
>                 hdev->in_debug = 0;
>
>                 goto out;
> --
> 2.17.1
>
Both patches are:
Reviewed-by: Oded Gabbay <oded.gabbay@xxxxxxxxx>
Applied to -next
Thanks,
Oded