Re: [PATCH v2] mmc: tegra: fix SDR50 tuning override

[Adrian Hunter]

On 6/01/20 2:36 pm, MichaÅ MirosÅaw wrote:
> Commit 7ad2ed1dfcbe inadvertently mixed up a quirk flag's name and
> broke SDR50 tuning override. Use correct NVQUIRK_ name.
> 
> Fixes: 7ad2ed1dfcbe ("mmc: tegra: enable UHS-I modes")
> Cc: <stable@xxxxxxxxxxxxxxx> # 4f6aa3264af4: mmc: tegra: Only advertise UHS modes if IO regulator is present
> Cc: <stable@xxxxxxxxxxxxxxx>
> Signed-off-by: MichaÅ MirosÅaw <mirq-linux@xxxxxxxxxxxx>

You should have included Thierry's Reviewed-by and Tested-by

Otherwise:

Acked-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>

> ---
>  v2: converted 'Depends-On' tag to proper 'Cc: stable' lines
> ---
>  drivers/mmc/host/sdhci-tegra.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
> index 7bc950520fd9..403ac44a7378 100644
> --- a/drivers/mmc/host/sdhci-tegra.c
> +++ b/drivers/mmc/host/sdhci-tegra.c
> @@ -386,7 +386,7 @@ static void tegra_sdhci_reset(struct sdhci_host *host, u8 mask)
>  			misc_ctrl |= SDHCI_MISC_CTRL_ENABLE_DDR50;
>  		if (soc_data->nvquirks & NVQUIRK_ENABLE_SDR104)
>  			misc_ctrl |= SDHCI_MISC_CTRL_ENABLE_SDR104;
> -		if (soc_data->nvquirks & SDHCI_MISC_CTRL_ENABLE_SDR50)
> +		if (soc_data->nvquirks & NVQUIRK_ENABLE_SDR50)
>  			clk_ctrl |= SDHCI_CLOCK_CTRL_SDR50_TUNING_OVERRIDE;
>  	}
>  
>