Re: [PATCH v3 02/22] compat: provide compat_ptr() on all architectures

[H. Peter Anvin]

<linuxppc-dev@xxxxxxxxxxxxxxxx>,oprofile-list@xxxxxxxxxxxx,linux-s390 <linux-s390@xxxxxxxxxxxxxxx>,sparclinux <sparclinux@xxxxxxxxxxxxxxx>
From: hpa@xxxxxxxxx
Message-ID: <41625F06-D755-4C82-86DF-A9415FEEE13D@xxxxxxxxx>

On January 7, 2020 12:08:31 AM PST, Arnd Bergmann <arnd@xxxxxxxx> wrote:
>On Tue, Jan 7, 2020 at 3:05 AM Michael Ellerman <mpe@xxxxxxxxxxxxxx>
>wrote:
>> Arnd Bergmann <arnd@xxxxxxxx> writes:
>> > +
>> > +static inline compat_uptr_t ptr_to_compat(void __user *uptr)
>> > +{
>> > +     return (u32)(unsigned long)uptr;
>> > +}
>>
>> Is there a reason we cast to u32 directly instead of using
>compat_uptr_t?
>
>Probably Al found this to be more explicit at the time when he
>introduced
>it on all the architectures in 2005. I just moved it here and kept the
>definition.
>
>       Arnd

Did compat_uptr_t exist back then?
-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.