Re: [EXT] [PATCH] spi: nxp-fspi: Ensure width is respected in spi-mem operations

[Michael Walle]

Am 2020-01-07 06:39, schrieb Kuldeep Singh:
> Hi Michael,
>
> > -----Original Message-----
> > From: linux-kernel-owner@xxxxxxxxxxxxxxx <linux-kernel-
> > owner@xxxxxxxxxxxxxxx> On Behalf Of Michael Walle
> > Sent: Thursday, December 12, 2019 1:28 AM
> > To: linux-spi@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> > Cc: Yogesh Gaur <yogeshgaur.83@xxxxxxxxx>; Ashish Kumar
> > <ashish.kumar@xxxxxxx>; Mark Brown <broonie@xxxxxxxxxx>; Michael
> > Walle <michael@xxxxxxxx>
> > Subject: [EXT] [PATCH] spi: nxp-fspi: Ensure width is respected in 
> > spi-mem
> > operations
> >
> > Caution: EXT Email
> >
> > Make use of a core helper to ensure the desired width is respected 
> > when
> > calling spi-mem operators.
> >
> > Otherwise only the SPI controller will be matched with the flash chip, 
> > which
> > might lead to wrong widths. Also consider the width specified by the 
> > user in
> > the device tree.
>
> Could you please mention the flash and modes you tested. Does it
> support DUAL/QUAD mode?
> I couldn't test these modes as NXP LS1028ARDB has "mt35xu02g" which
> supports SINGLE and OCTAL modes only.

That commit is already upstream. But FWIW, it was a Winbond W25Q32FW in 
dual i/o mode.

-michael