Re: [PATCH 07/12] i2c: xiic: convert to use i2c_new_client_device()

From: Michal Simek
Date: Wed Jan 08 2020 - 06:39:27 EST


On 07. 01. 20 18:47, Wolfram Sang wrote:
> Move away from the deprecated API and return the shiny new ERRPTR where
> useful.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> ---
> Build tested only.
>
> drivers/i2c/busses/i2c-xiic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
> index d8d49f1814c7..61e081b186cc 100644
> --- a/drivers/i2c/busses/i2c-xiic.c
> +++ b/drivers/i2c/busses/i2c-xiic.c
> @@ -806,7 +806,7 @@ static int xiic_i2c_probe(struct platform_device *pdev)
> if (pdata) {
> /* add in known devices to the bus */
> for (i = 0; i < pdata->num_devices; i++)
> - i2c_new_device(&i2c->adap, pdata->devices + i);
> + i2c_new_client_device(&i2c->adap, pdata->devices + i);
> }
>
> return 0;
>

Acked-by: Michal Simek <michal.simek@xxxxxxxxxx>

Shubhrajyoti: Can you please retest?

Thanks,
Michal