Re: [PATCH next] drm/i915/gtt: add missing include file asm/smp.h

From: Jani Nikula
Date: Wed Jan 08 2020 - 08:44:28 EST


On Wed, 08 Jan 2020, Chen Zhou <chenzhou10@xxxxxxxxxx> wrote:
> Fix build error:
> lib/crypto/chacha.c: In function chacha_permute:
> lib/crypto/chacha.c:65:1: warning: the frame size of 3384 bytes is larger than 2048 bytes [-Wframe-larger-than=]
> }
> ^

IMO this needs a better explanation of why not having the include leads
to the above failure.

BR,
Jani.

>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Chen Zhou <chenzhou10@xxxxxxxxxx>
> ---
> drivers/gpu/drm/i915/gt/intel_ggtt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_ggtt.c b/drivers/gpu/drm/i915/gt/intel_ggtt.c
> index 1a2b5dc..9ef8ed8 100644
> --- a/drivers/gpu/drm/i915/gt/intel_ggtt.c
> +++ b/drivers/gpu/drm/i915/gt/intel_ggtt.c
> @@ -6,6 +6,7 @@
> #include <linux/stop_machine.h>
>
> #include <asm/set_memory.h>
> +#include <asm/smp.h>
>
> #include "intel_gt.h"
> #include "i915_drv.h"

--
Jani Nikula, Intel Open Source Graphics Center