Re: [PATCH v2 09/36] platform/x86: intel_scu_ipc: Drop unused macros

From: Andy Shevchenko
Date: Wed Jan 08 2020 - 11:41:48 EST


On Wed, Jan 08, 2020 at 02:41:34PM +0300, Mika Westerberg wrote:
> These macros are not used anywhere in the driver so drop them.
>

Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

> Signed-off-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> ---
> drivers/platform/x86/intel_scu_ipc.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/platform/x86/intel_scu_ipc.c b/drivers/platform/x86/intel_scu_ipc.c
> index 8db0644900a3..997fdac920c6 100644
> --- a/drivers/platform/x86/intel_scu_ipc.c
> +++ b/drivers/platform/x86/intel_scu_ipc.c
> @@ -26,11 +26,7 @@
> #include <asm/intel_scu_ipc.h>
>
> /* IPC defines the following message types */
> -#define IPCMSG_WATCHDOG_TIMER 0xF8 /* Set Kernel Watchdog Threshold */
> -#define IPCMSG_BATTERY 0xEF /* Coulomb Counter Accumulator */
> -#define IPCMSG_FW_UPDATE 0xFE /* Firmware update */
> -#define IPCMSG_PCNTRL 0xFF /* Power controller unit read/write */
> -#define IPCMSG_FW_REVISION 0xF4 /* Get firmware revision */
> +#define IPCMSG_PCNTRL 0xff /* Power controller unit read/write */
>
> /* Command id associated with message IPCMSG_PCNTRL */
> #define IPC_CMD_PCNTRL_W 0 /* Register write */
> --
> 2.24.1
>

--
With Best Regards,
Andy Shevchenko