Re: [PATCH ghak25 v2 1/9] netfilter: normalize x_table function declarations

From: Nicolas Dichtel
Date: Wed Jan 08 2020 - 11:47:17 EST


Le 06/01/2020 Ã 19:54, Richard Guy Briggs a ÃcritÂ:
> Git context diffs were being produced with unhelpful declaration types
> in the place of function names to help identify the funciton in which
> changes were made.
Just for my information, how do you reproduce that? With a 'git diff'?

>
> Normalize x_table function declarations so that git context diff
> function labels work as expected.
>
[snip]
>
> --
> 1.8.3.1
git v1.8.3.1 is seven years old:
https://github.com/git/git/releases/tag/v1.8.3.1

I don't see any problems with git v2.24. Not sure that the patch brings any
helpful value except complicating backports.

Regards,
Nicolas