Re: [PATCH -next] drm/mgag200: Fix typo in parameter description

From: Thomas Zimmermann
Date: Fri Jan 10 2020 - 03:28:17 EST


Hi

Am 10.01.20 um 02:25 schrieb Wei Yongjun:
> Fix typo in parameter description.

As Dan said, please mention that it's about a module parameter. The
current commit message appears to refer to a function's parameter.

With the commit message fixed, you can add

Reviewed-by: Thomas Zimemrmann <tzimmermann@xxxxxxx>

Thanks for fixing this bug.

Best regards
Thomas

>
> Fixes: 3cacb2086e41 ("drm/mgag200: Add module parameter to pin all buffers at offset 0")
> Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
> ---
> drivers/gpu/drm/mgag200/mgag200_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c b/drivers/gpu/drm/mgag200/mgag200_drv.c
> index 7a5bad2f57d7..2236f8ef20a4 100644
> --- a/drivers/gpu/drm/mgag200/mgag200_drv.c
> +++ b/drivers/gpu/drm/mgag200/mgag200_drv.c
> @@ -28,7 +28,7 @@ MODULE_PARM_DESC(modeset, "Disable/Enable modesetting");
> module_param_named(modeset, mgag200_modeset, int, 0400);
>
> int mgag200_hw_bug_no_startadd = -1;
> -MODULE_PARM_DESC(modeset, "HW does not interpret scanout-buffer start address correctly");
> +MODULE_PARM_DESC(hw_bug_no_startadd, "HW does not interpret scanout-buffer start address correctly");
> module_param_named(hw_bug_no_startadd, mgag200_hw_bug_no_startadd, int, 0400);
>
> static struct drm_driver driver;
>
>
>

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 NÃrnberg, Germany
(HRB 36809, AG NÃrnberg)
GeschÃftsfÃhrer: Felix ImendÃrffer

Attachment: signature.asc
Description: OpenPGP digital signature