RE: [PATCH net-next v2 2/8] net: stmmac: tc: Add support for ETF Scheduler using TBS

From: Jose Abreu
Date: Mon Jan 13 2020 - 10:18:26 EST


From: Jakub Kicinski <kuba@xxxxxxxxxx>
Date: Jan/13/2020, 15:12:51 (UTC+00:00)

> On Mon, 13 Jan 2020 14:02:37 +0100, Jose Abreu wrote:
> > +static int tc_setup_etf(struct stmmac_priv *priv,
> > + struct tc_etf_qopt_offload *qopt)
> > +{
> > +
>
> There's a couple places I spotted where continuation lines are not
> aligned to the opening parenthesis, and here we have a spurious blank
> line. Please run this through checkpatch --strict, I see quite a few
> legit errors there.

Yeah, there are two errors that were left from debug ... Sorry :(

---
Thanks,
Jose Miguel Abreu