Re: [PATCH v3 3/3] drm/panel: simple: Add support for the Frida FRD350H54004 panel

From: Sam Ravnborg
Date: Mon Jan 13 2020 - 12:33:25 EST


Hi Paul.

On Mon, Jan 13, 2020 at 01:17:41PM -0300, Paul Cercueil wrote:
> The FRD350H54004 is a simple 3.5" 320x240 24-bit TFT panel, found for
> instance inside the Anbernic RG-350 handheld gaming console.
>
> v2: Order alphabetically
> v3: Add connector_type, and update timings according to the constraints
> listed in the datasheet
>
> Signed-off-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>

Thanks, applied to drm-misc-next.

Sam
> ---
> drivers/gpu/drm/panel/panel-simple.c | 30 ++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index e14c14ac62b5..d6f77bc494c7 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1440,6 +1440,33 @@ static const struct panel_desc foxlink_fl500wvr00_a0t = {
> .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> };
>
> +static const struct drm_display_mode frida_frd350h54004_mode = {
> + .clock = 6000,
> + .hdisplay = 320,
> + .hsync_start = 320 + 44,
> + .hsync_end = 320 + 44 + 16,
> + .htotal = 320 + 44 + 16 + 20,
> + .vdisplay = 240,
> + .vsync_start = 240 + 2,
> + .vsync_end = 240 + 2 + 6,
> + .vtotal = 240 + 2 + 6 + 2,
> + .vrefresh = 60,
> + .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC,
> +};
> +
> +static const struct panel_desc frida_frd350h54004 = {
> + .modes = &frida_frd350h54004_mode,
> + .num_modes = 1,
> + .bpc = 8,
> + .size = {
> + .width = 77,
> + .height = 64,
> + },
> + .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_POSEDGE,
> + .connector_type = DRM_MODE_CONNECTOR_DPI,
> +};
> +
> static const struct drm_display_mode friendlyarm_hd702e_mode = {
> .clock = 67185,
> .hdisplay = 800,
> @@ -3309,6 +3336,9 @@ static const struct of_device_id platform_of_match[] = {
> }, {
> .compatible = "foxlink,fl500wvr00-a0t",
> .data = &foxlink_fl500wvr00_a0t,
> + }, {
> + .compatible = "frida,frd350h54004",
> + .data = &frida_frd350h54004,
> }, {
> .compatible = "friendlyarm,hd702e",
> .data = &friendlyarm_hd702e,
> --
> 2.24.1