Re: [PATCH] USB: serial: opticon: fix control-message timeouts

From: Greg KH
Date: Mon Jan 13 2020 - 13:25:51 EST


On Mon, Jan 13, 2020 at 06:22:13PM +0100, Johan Hovold wrote:
> The driver was issuing synchronous uninterruptible control requests
> without using a timeout. This could lead to the driver hanging
> on open() or tiocmset() due to a malfunctioning (or malicious) device
> until the device is physically disconnected.
>
> The USB upper limit of five seconds per request should be more than
> enough.
>
> Fixes: 309a057932ab ("USB: opticon: add rts and cts support")
> Cc: stable <stable@xxxxxxxxxxxxxxx> # 2.6.39
> Cc: Martin Jansen <martin.jansen@xxxxxxxxxxx>
> Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>

Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>