Re: [PATCH] media: usbtv: fix control-message timeouts

From: Greg KH
Date: Mon Jan 13 2020 - 13:26:05 EST


On Mon, Jan 13, 2020 at 06:18:18PM +0100, Johan Hovold wrote:
> The driver was issuing synchronous uninterruptible control requests
> without using a timeout. This could lead to the driver hanging on
> various user requests due to a malfunctioning (or malicious) device
> until the device is physically disconnected.
>
> The USB upper limit of five seconds per request should be more than
> enough.
>
> Fixes: f3d27f34fdd7 ("[media] usbtv: Add driver for Fushicai USBTV007 video frame grabber")
> Fixes: c53a846c48f2 ("[media] usbtv: add video controls")
> Cc: stable <stable@xxxxxxxxxxxxxxx> # 3.11
> Cc: Lubomir Rintel <lkundrak@xxxxx>
> Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>

Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>