Re: [PATCH 1/2] perf/ui/gtk: Add missing zalloc object

From: Arnaldo Carvalho de Melo
Date: Tue Jan 14 2020 - 10:25:36 EST


Em Mon, Jan 13, 2020 at 11:43:57AM +0100, Jiri Olsa escreveu:
> When we moved zalloc.o to the library we missed gtk library
> which needs it compiled in, otherwise the missing __zfree
> symbol will cause the library to fail to load.
>
> Adding the zalloc object to the gtk library build.

Thanks, applied.

- Arnaldo

> Fixes: 7f7c536f23e6 ("tools lib: Adopt zalloc()/zfree() from tools/perf")
> Link: https://lkml.kernel.org/n/tip-nuu3lyzzmi2t9zdvlg0i0bh0@xxxxxxxxxxxxxx
> Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>
> ---
> tools/perf/ui/gtk/Build | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/tools/perf/ui/gtk/Build b/tools/perf/ui/gtk/Build
> index ec22e899a224..9b5d5cbb7af7 100644
> --- a/tools/perf/ui/gtk/Build
> +++ b/tools/perf/ui/gtk/Build
> @@ -7,3 +7,8 @@ gtk-y += util.o
> gtk-y += helpline.o
> gtk-y += progress.o
> gtk-y += annotate.o
> +gtk-y += zalloc.o
> +
> +$(OUTPUT)ui/gtk/zalloc.o: ../lib/zalloc.c FORCE
> + $(call rule_mkdir)
> + $(call if_changed_dep,cc_o_c)
> --
> 2.24.1
>

--

- Arnaldo