Re: [PATCH V2] firmware: arm_scmi: Make scmi core independent of transport type

From: peter.hilber
Date: Wed Jan 15 2020 - 14:43:17 EST


On 14.01.20 12:11, Viresh Kumar wrote:
> Okay, I think I understand that a bit now. So here are the things
> which I may need to do now:
>
> - Maybe move payload to struct scmi_mailbox structure, as that is the
> transport dependent structure..
>
> - Do ioremap, etc in mailbox.c only instead of driver.c
>
> - Provide more ops in struct scmi_transport_ops to provide read/write
> helpers to the payload and implement the ones based on
> ioread/iowrite in mailbox.c ..
>
> Am I thinking in the right direction now ?
>

Another related issue IMHO:

The "shmem" DT property, which is mapped to payload, will not be used
for the planned SCMI virtio transport. But currently "shmem" is still
required by scmi_chan_setup().

Best regards,

Peter

Please mind our privacy notice<https://www.opensynergy.com/datenschutzerklaerung/privacy-notice-for-business-partners-pursuant-to-article-13-of-the-general-data-protection-regulation-gdpr/> pursuant to Art. 13 GDPR. // Unsere Hinweise zum Datenschutz gem. Art. 13 DSGVO finden Sie hier.<https://www.opensynergy.com/de/datenschutzerklaerung/datenschutzhinweise-fuer-geschaeftspartner-gem-art-13-dsgvo/>