Re: [PATCH] net/wan/fsl_ucc_hdlc: fix out of bounds write on array utdm_info

From: David Miller
Date: Wed Jan 15 2020 - 17:06:45 EST


From: Colin King <colin.king@xxxxxxxxxxxxx>
Date: Tue, 14 Jan 2020 14:54:48 +0000

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Array utdm_info is declared as an array of MAX_HDLC_NUM (4) elements
> however up to UCC_MAX_NUM (8) elements are potentially being written
> to it. Currently we have an array out-of-bounds write error on the
> last 4 elements. Fix this by making utdm_info UCC_MAX_NUM elements in
> size.
>
> Addresses-Coverity: ("Out-of-bounds write")
> Fixes: c19b6d246a35 ("drivers/net: support hdlc function for QE-UCC")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Applied and queued up for -stable.