Re: [PATCH] KVM: arm/arm64: Fix some obsolete comments

From: linmiaohe
Date: Wed Jan 15 2020 - 21:01:31 EST


friendly ping. :)
> From: Miaohe Lin <linmiaohe@xxxxxxxxxx>
>
> Fix various comments, including comment typo, and obsolete comments no longer make sense.
> Signed-off-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>
> ---
> virt/kvm/arm/arch_timer.c | 5 ++---
> virt/kvm/arm/arm.c | 1 -
> virt/kvm/arm/vgic/vgic-its.c | 2 +-
> 3 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/virt/kvm/arm/arch_timer.c b/virt/kvm/arm/arch_timer.c index 73867f97040c..d8d2f4bec935 100644
> --- a/virt/kvm/arm/arch_timer.c
> +++ b/virt/kvm/arm/arch_timer.c
> @@ -322,9 +322,8 @@ static void timer_emulate(struct arch_timer_context *ctx)
> }
>
> /*
> - * If the timer can fire now, we don't need to have a soft timer
> - * scheduled for the future. If the timer cannot fire at all,
> - * then we also don't need a soft timer.
> + * If the timer cannot fire at all, we don't need to have a
> + * soft timer scheduled for the future.
> */
> if (!kvm_timer_irq_can_fire(ctx)) {
> soft_timer_cancel(&ctx->hrtimer);
> diff --git a/virt/kvm/arm/arm.c b/virt/kvm/arm/arm.c index 8de4daf25097..7687663ab71b 100644
> --- a/virt/kvm/arm/arm.c
> +++ b/virt/kvm/arm/arm.c
> @@ -525,7 +525,6 @@ static bool need_new_vmid_gen(struct kvm_vmid *vmid)
>
> /**
> * update_vmid - Update the vmid with a valid VMID for the current generation
> - * @kvm: The guest that struct vmid belongs to
> * @vmid: The stage-2 VMID information struct
> */
> static void update_vmid(struct kvm_vmid *vmid) diff --git a/virt/kvm/arm/vgic/vgic-its.c b/virt/kvm/arm/vgic/vgic-its.c index 98c7360d9fb7..d64569b30b5c 100644
> --- a/virt/kvm/arm/vgic/vgic-its.c
> +++ b/virt/kvm/arm/vgic/vgic-its.c
> @@ -2564,7 +2564,7 @@ static int vgic_its_restore_collection_table(struct vgic_its *its) }
>
> /**
> - * vgic_its_save_tables_v0 - Save the ITS tables into guest ARM
> + * vgic_its_save_tables_v0 - Save the ITS tables into guest RAM
> * according to v0 ABI
> */
> static int vgic_its_save_tables_v0(struct vgic_its *its)
> --
> 2.19.1
>