Re: [PATCH v2] pinctrl/rockchip: splite soc data to separated driver

[Kever Yang]

On 2020/1/15 äå8:51, Linus Walleij wrote:
> On Mon, Jan 13, 2020 at 2:16 AM Jianqun Xu <jay.xu@xxxxxxxxxxxxxx> wrote:
>
> > * Decrease codes of pinctrl-rockchip.c from 4,000 lines to 2000 by
> > separating soc data to a new file.
> >
> > * Move rockchip pinctrl related struct definations to a head file.
> >
> > * Keep legency pinctrl-rockchip.c under driver/pinctrl but not to
> > compile it, conveniently for reviewers.
> >
> > Signed-off-by: Jianqun Xu <jay.xu@xxxxxxxxxxxxxx>
> This patch looks good, two things are missing:
>
> - Review from Heiko
>
> - A change to MAINTAINERS so that the file pattern still
>    matches
>
> Should someone from Rockchip also sign up as comaintainer
> for this driver by the way? (Though the people at Rockchip
> posting patches for this seem to change a bit.)


The kernel Image size is keep growing, this patch can help reduce the 
size of

kernel image for one SoC, and this is what we have done in U-Boot mainline.

And for distribution kernel who need to cover all the SoCs with one 
kernel image,

need to update the defconfig.

The patch looks good to me,

Reviewed-by: Kever Yang <kever.yang@xxxxxxxxxxxxxx>

Thanks,
- Kever


> Yours,
> Linus Walleij