Re: [PATCH -next v4] mm/hotplug: silence a lockdep splat with printk()

From: Sergey Senozhatsky
Date: Thu Jan 16 2020 - 21:50:02 EST


On (20/01/16 21:21), Qian Cai wrote:
> It is not that hard to trigger lockdep splats by calling printk from
> under zone->lock. Most of them are false positives caused by lock chains
> introduced early in the boot process and they do not cause any real
> problems (although some of the early boot lock dependencies could
> happenn after boot as well). There are some console drivers which do
> allocate from the printk context as well and those should be fixed. In
> any case false positives are not that trivial to workaround and it is
> far from optimal to lose lockdep functionality for something that is a
> non-issue.
[..]
>
> Acked-by: Michal Hocko <mhocko@xxxxxxxx>
> Signed-off-by: Qian Cai <cai@xxxxxx>

FWIW,
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>

-ss