Re: [PATCH v3 6/8] locking/lockdep: Reuse freed chain_hlocks entries

From: kbuild test robot
Date: Fri Jan 17 2020 - 00:51:32 EST


Hi Waiman,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/locking/core]
[also build test ERROR on tip/auto-latest linus/master arm-perf/for-next/perf v5.5-rc6 next-20200116]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url: https://github.com/0day-ci/linux/commits/Waiman-Long/locking-lockdep-Reuse-zapped-chain_hlocks-entries/20200117-093009
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 1a365e822372ba24c9da0822bc583894f6f3d821
config: i386-randconfig-d002-20200117 (attached as .config)
compiler: gcc-7 (Debian 7.5.0-3) 7.5.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

kernel/locking/lockdep.c: In function 'lockdep_init':
>> kernel/locking/lockdep.c:5387:2: error: implicit declaration of function 'init_chain_block_buckets' [-Werror=implicit-function-declaration]
init_chain_block_buckets();
^~~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors

vim +/init_chain_block_buckets +5387 kernel/locking/lockdep.c

5384
5385 void __init lockdep_init(void)
5386 {
> 5387 init_chain_block_buckets();
5388
5389 printk("Lock dependency validator: Copyright (c) 2006 Red Hat, Inc., Ingo Molnar\n");
5390
5391 printk("... MAX_LOCKDEP_SUBCLASSES: %lu\n", MAX_LOCKDEP_SUBCLASSES);
5392 printk("... MAX_LOCK_DEPTH: %lu\n", MAX_LOCK_DEPTH);
5393 printk("... MAX_LOCKDEP_KEYS: %lu\n", MAX_LOCKDEP_KEYS);
5394 printk("... CLASSHASH_SIZE: %lu\n", CLASSHASH_SIZE);
5395 printk("... MAX_LOCKDEP_ENTRIES: %lu\n", MAX_LOCKDEP_ENTRIES);
5396 printk("... MAX_LOCKDEP_CHAINS: %lu\n", MAX_LOCKDEP_CHAINS);
5397 printk("... CHAINHASH_SIZE: %lu\n", CHAINHASH_SIZE);
5398
5399 printk(" memory used by lock dependency info: %zu kB\n",
5400 (sizeof(lock_classes) +
5401 sizeof(lock_classes_in_use) +
5402 sizeof(classhash_table) +
5403 sizeof(list_entries) +
5404 sizeof(list_entries_in_use) +
5405 sizeof(chainhash_table) +
5406 sizeof(delayed_free)
5407 #ifdef CONFIG_PROVE_LOCKING
5408 + sizeof(lock_cq)
5409 + sizeof(lock_chains)
5410 + sizeof(lock_chains_in_use)
5411 + sizeof(chain_hlocks)
5412 #endif
5413 ) / 1024
5414 );
5415

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx Intel Corporation

Attachment: .config.gz
Description: application/gzip