Re: [PATCH v10 05/14] exfat: add file operations

[Namjae Jeon]

2020-01-17 17:18 GMT+08:00, Pali RohÃr <pali.rohar@xxxxxxxxx>:
> On Wednesday 15 January 2020 17:24:38 Namjae Jeon wrote:
>> This adds the implementation of file operations for exfat.
>>
>> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
>> Signed-off-by: Namjae Jeon <namjae.jeon@xxxxxxxxxxx>
>> Signed-off-by: Sungjong Seo <sj1557.seo@xxxxxxxxxxx>
>> ---
>>  fs/exfat/file.c | 355 ++++++++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 355 insertions(+)
>>  create mode 100644 fs/exfat/file.c
>>
>> diff --git a/fs/exfat/file.c b/fs/exfat/file.c
>> new file mode 100644
>> index 000000000000..b4b8af0cae0a
>> --- /dev/null
>> +++ b/fs/exfat/file.c
>
> ...
>
>> +/* resize the file length */
>> +int __exfat_truncate(struct inode *inode, loff_t new_size)
>> +{
>
> ...
>
>> +
>> +		ktime_get_real_ts64(&ts);
>> +		exfat_set_entry_time(sbi, &ts,
>> +				&ep->dentry.file.modify_time,
>> +				&ep->dentry.file.modify_date,
>> +				&ep->dentry.file.modify_tz);
>
> Hello! Now I spotted that you forgot to update "modify_time_ms" entry.
Good catch:)
>
> To prevent this problem, maybe function modify_time_ms() could take
> another (optional) parameter for specifying time_ms?
Okay, I will change exfat_set/get_entry_time to take a time_ms argument.
Thanks for your review!