Re: [PATCH v1 1/2] x86/msi: Enhance x86 to support platform_msi

[Thomas Gleixner]

Zha Bin <zhabin@xxxxxxxxxxxxxxxxx> writes:

> From: Liu Jiang <gerry@xxxxxxxxxxxxxxxxx>
>
> The x86 platform currently only supports specific MSI/MSI-x for PCI
> devices. To enable MSI to the platform devices such as virtio-mmio
> device, this patch enhances x86 with platform MSI by leveraging the
> already built-in platform-msi driver (drivers/base/platform-msi.c)
> and makes it as a configurable option.

Why are you trying to make this an architecture feature instead of
having a generic implementation which can work on all architectures
which support virtio-mmio?

> Signed-off-by: Liu Jiang <gerry@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Zha Bin <zhabin@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Chao Peng <chao.p.peng@xxxxxxxxxxxxxxx>
> Signed-off-by: Jing Liu <jing2.liu@xxxxxxxxxxxxxxx>

This Signed-off-by chain is invalid.

Thanks,

        tglx