Re: [PATCHv2 1/2] dt-bindings: usb: dwc2: add support for STM32MP15 SoCs USB OTG HS and FS

[Rob Herring]

On Thu, Jan 16, 2020 at 03:45:23PM +0100, Amelie Delaunay wrote:
> Add the specific compatible string for the DWC2 IP found in the STM32MP15
> SoCs.
> STM32MP15 SoCs uses sensing comparators to detect Vbus valid levels and
> ID pin state. usb33d-supply described the regulator supplying Vbus and ID
> sensing comparators.
> 
> Signed-off-by: Amelie Delaunay <amelie.delaunay@xxxxxx>
> ---
>  Documentation/devicetree/bindings/usb/dwc2.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/dwc2.yaml b/Documentation/devicetree/bindings/usb/dwc2.yaml
> index 71cf7ba32237..0b86250b97a9 100644
> --- a/Documentation/devicetree/bindings/usb/dwc2.yaml
> +++ b/Documentation/devicetree/bindings/usb/dwc2.yaml
> @@ -58,6 +58,8 @@ properties:
>        - const: st,stm32f4x9-fsotg
>        - const: st,stm32f4x9-hsotg
>        - const: st,stm32f7-hsotg
> +      - const: st,stm32mp15-fsotg
> +      - const: st,stm32mp15-hsotg
>        - const: samsung,s3c6400-hsotg
>  
>    reg:
> @@ -103,6 +105,10 @@ properties:
>    vusb_a-supply:
>      description: phandle to voltage regulator of analog section.
>  
> +  vusb33d_supply:

Not a valid regulator property.

> +    description: reference to the external VBUS and ID sensing comparators, in
> +      order to perform OTG operation, used on STM32MP15 SoCs.

Are they external or part of the SoC? When we have Vbus sense and ID 
GPIOs, those go in the connector node, so this probably should too if 
these are board components.

Rob