Re: [PATCH] xen/blkfront: limit allocated memory size to actual use case

From: Roger Pau Monné
Date: Fri Jan 17 2020 - 10:13:36 EST


On Fri, Jan 17, 2020 at 03:39:55PM +0100, Juergen Gross wrote:
> Today the Xen blkfront driver allocates memory for one struct
> blkfront_ring_info for each communication ring. This structure is
> statically sized for the maximum supported configuration resulting
> in a size of more than 90 kB.
>
> As the main size contributor is one array inside the struct, the
> memory allocation can easily be limited by moving this array to be
> the last structure element and to allocate only the memory for the
> actually needed array size.
>
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>

Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Thanks! It would be nice to backport this, but I'm not sure it would
qualify as a bug fix.

Roger.