Re: [PATCH 1/2] mm: add helpers pmdp_modify_prot_start/commit

[kbuild test robot]

Hi Xuefeng,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on mmotm/master]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Xuefeng-Wang/mm-thp-rework-the-pmd-protect-changing-flow/20200117-115821
base:   git://git.cmpxchg.org/linux-mmotm.git master
config: nds32-defconfig (attached as .config)
compiler: nds32le-linux-gcc (GCC) 9.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=9.2.0 make.cross ARCH=nds32 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   In file included from arch/nds32/include/asm/pgtable.h:394,
                    from include/linux/mm.h:99,
                    from include/linux/ring_buffer.h:5,
                    from include/linux/trace_events.h:6,
                    from include/trace/syscall.h:7,
                    from include/linux/syscalls.h:85,
                    from init/main.c:21:
   include/asm-generic/pgtable.h: In function '__pmdp_modify_prot_commit':
>> include/asm-generic/pgtable.h:677:2: error: implicit declaration of function 'set_pmd_at'; did you mean 'set_pte_at'? [-Werror=implicit-function-declaration]
     677 |  set_pmd_at(vma->vm_mm, addr, pmdp, pmd);
         |  ^~~~~~~~~~
         |  set_pte_at
   cc1: some warnings being treated as errors
--
   In file included from arch/nds32/include/asm/pgtable.h:394,
                    from include/linux/mm.h:99,
                    from arch/nds32/include/asm/uaccess.h:14,
                    from include/linux/uaccess.h:11,
                    from include/linux/sched/task.h:11,
                    from include/linux/sched/signal.h:9,
                    from include/linux/ptrace.h:7,
                    from arch/nds32/kernel/signal.c:6:
   include/asm-generic/pgtable.h: In function '__pmdp_modify_prot_commit':
>> include/asm-generic/pgtable.h:677:2: error: implicit declaration of function 'set_pmd_at'; did you mean 'set_pte_at'? [-Werror=implicit-function-declaration]
     677 |  set_pmd_at(vma->vm_mm, addr, pmdp, pmd);
         |  ^~~~~~~~~~
         |  set_pte_at
   arch/nds32/kernel/signal.c: In function 'do_signal':
   arch/nds32/kernel/signal.c:362:20: warning: this statement may fall through [-Wimplicit-fallthrough=]
     362 |    regs->uregs[15] = __NR_restart_syscall;
   arch/nds32/kernel/signal.c:363:3: note: here
     363 |   case -ERESTARTNOHAND:
         |   ^~~~
   arch/nds32/kernel/signal.c: In function 'handle_signal':
   arch/nds32/kernel/signal.c:315:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
     315 |    if (!(ksig->ka.sa.sa_flags & SA_RESTART)) {
         |       ^
   arch/nds32/kernel/signal.c:319:3: note: here
     319 |   case -ERESTARTNOINTR:
         |   ^~~~
   cc1: some warnings being treated as errors

vim +677 include/asm-generic/pgtable.h

   672	
   673	static inline void __pmdp_modify_prot_commit(struct vm_area_struct *vma,
   674							unsigned long addr,
   675							pmd_t *pmdp, pmd_t pmd)
   676	{
 > 677		set_pmd_at(vma->vm_mm, addr, pmdp, pmd);
   678	}
   679	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx Intel Corporation

Attachment: .config.gz
Description: application/gzip