Re: [PATCH RFC v1] mm: is_mem_section_removable() overhaul

From: Michal Hocko
Date: Mon Jan 20 2020 - 02:48:29 EST


On Fri 17-01-20 08:57:51, Dan Williams wrote:
[...]
> Unless the user is willing to hold the device_hotplug_lock over the
> evaluation then the result is unreliable.

Do we want to hold the device_hotplug_lock from this user readable file
in the first place? My book says that this just waits to become a
problem.

Really, the interface is flawed and should have never been merged in the
first place. We cannot simply remove it altogether I am afraid so let's
at least remove the bogus code and pretend that the world is a better
place where everything is removable except the reality sucks...
--
Michal Hocko
SUSE Labs