Re: [PATCH V2] pwm: remove set but not set variable 'pwm'

From: Uwe Kleine-König
Date: Mon Jan 20 2020 - 09:21:44 EST


On Mon, Jan 20, 2020 at 07:51:43PM +0800, yu kuai wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/pwm/pwm-pca9685.c: In function âpca9685_pwm_gpio_freeâ:
> drivers/pwm/pwm-pca9685.c:162:21: warning: variable âpwmâ set but
> not used [-Wunused-but-set-variable]
>
> It is never used, and so can be removed. In that case, hold and release
> the lock 'pac->lock' can be removed since nothing will be done between
> them.
>
> Fixes: e926b12c611c ("pwm: Clear chip_data in pwm_put()")
> Signed-off-by: yu kuai <yukuai3@xxxxxxxxxx>

Acked-by: Uwe Kleine-KÃnig <u.kleine-koenig@xxxxxxxxxxxxxx>

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-KÃnig |
Industrial Linux Solutions | https://www.pengutronix.de/ |