Re: [PATCH] lib/bitmap: remove expect_eq_u32_array

[Andy Shevchenko]

On Tue, Jan 21, 2020 at 05:10:18PM -0800, Yury Norov wrote:
> On Tue, Jan 21, 2020 at 03:20:50PM +0200, Andy Shevchenko wrote:
> > On Tue, Jan 21, 2020 at 04:33:45PM +0800, Alex Shi wrote:
> > > expect_eq_u32_array isn't used from commit 3aa56885e516 ("bitmap:
> > > replace bitmap_{from,to}_u32array").
> > > And EXP2_IN_BITS are never used. so better to remove them.
> > 
> > I think better "fix" will be to add test cases.
> > See the commit message in the
> > 
> > commit 3aa56885e51683a19c8aa71739fd279b3f501cd7
> > Author: Yury Norov <ynorov@xxxxxxxxxxxxxxxxxx>
> > Date:   Tue Feb 6 15:38:06 2018 -0800
> > 
> >     bitmap: replace bitmap_{from,to}_u32array

> On the other hand, it's almost 2 years gone since the commit you
> mentioned, and nobody used the check_eq_u32_array(). So I think
> it's long enough to consider the function useless.
> 
> This function is the last example of 2 lengths in input, so I'd
> prefer to remove it. However, removing check_eq_u32_array() should
> be synchronized with underlying __check_eq_u32_array().

Thanks for elaboration.
No objection from my side!

-- 
With Best Regards,
Andy Shevchenko