Re: [PATCH net-next 5/7] ethtool: provide WoL settings with WOL_GET request

[Andrew Lunn]

On Sun, Jan 26, 2020 at 11:11:13PM +0100, Michal Kubecek wrote:
> Implement WOL_GET request to get wake-on-lan settings for a device,
> traditionally available via ETHTOOL_GWOL ioctl request.
> 
> As part of the implementation, provide symbolic names for wake-on-line

Hi Michal

LAN, not line.

> modes as ETH_SS_WOL_MODES string set.

I think it would also be good to repeat here what you have in the
cover note, that unlike the ioctl version, CAP_NET_ADMIN is required.
The cover note does get committed to the git history, but it is a lot
less likely to be seen than this patches commit message.

> +WOL_GET
> +=======
> +
> +Query device wake-on-lan settings. Unlike most "GET" type requests,
> +``ETHTOOL_MSG_WOL_GET`` requires (netns) ``CAP_NET_ADMIN`` privileges as it
> +(potentially) provides SecureOn(tm) password which is confidential.

provides _the_ SecureOn(tm)

Apart from that:

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

    Andrew