Re: [PATCH 4.19 000/639] 4.19.99-stable review

From: Jon Hunter
Date: Mon Jan 27 2020 - 04:38:25 EST



On 26/01/2020 09:13, Greg Kroah-Hartman wrote:
> On Sat, Jan 25, 2020 at 07:46:47AM -0800, Guenter Roeck wrote:
>> On 1/25/20 3:32 AM, Jon Hunter wrote:
>>>
>>> On 24/01/2020 18:07, Jon Hunter wrote:
>>>>
>>>> On 24/01/2020 17:36, Greg Kroah-Hartman wrote:
>>>>> On Fri, Jan 24, 2020 at 02:50:05PM +0000, Jon Hunter wrote:
>>>>>> Hi Greg,
>>>>>>
>>>>>> On 24/01/2020 09:22, Greg Kroah-Hartman wrote:
>>>>>>> This is the start of the stable review cycle for the 4.19.99 release.
>>>>>>> There are 639 patches in this series, all will be posted as a response
>>>>>>> to this one. If anyone has any issues with these being applied, please
>>>>>>> let me know.
>>>>>>>
>>>>>>> Responses should be made by Sun, 26 Jan 2020 09:26:29 +0000.
>>>>>>> Anything received after that time might be too late.
>>>>>>>
>>>>>>> The whole patch series can be found in one patch at:
>>>>>>> https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.99-rc1.gz
>>>>>>> or in the git tree and branch at:
>>>>>>> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
>>>>>>> and the diffstat can be found below.
>>>>>>>
>>>>>>> thanks,
>>>>>>>
>>>>>>> greg k-h
>>>>>>>
>>>>>>> -------------
>>>>>>> Pseudo-Shortlog of commits:
>>>>>>
>>>>>> ...
>>>>>>
>>>>>>> Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
>>>>>>> PCI: PM: Skip devices in D0 for suspend-to-idle
>>>>>>
>>>>>> The above commit is causing a suspend regression on Tegra124 Jetson-TK1.
>>>>>> Reverting this on top of v4.19.99-rc1 fixes the issue.
>>>>>
>>>>> This is also in the 4.14 queue, so should I drop it there too?
>>>>
>>>> I did not see any failures with the same board on that branch, so I
>>>> would say no, but odd that it only fails here. It was failing for me
>>>> 100% so I would have expected to see if there too if it was a problem.
>>>
>>> Hmmm, rc2 still not working for me ...
>>>
>>> Test results for stable-v4.19:
>>> 11 builds: 11 pass, 0 fail
>>> 22 boots: 22 pass, 0 fail
>>> 32 tests: 30 pass, 2 fail
>>>
>>> Linux version: 4.19.99-rc2-g24832ad2c623
>>> Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,
>>> tegra194-p2972-0000, tegra20-ventana,
>>> tegra210-p2371-2180, tegra30-cardhu-a04
>>>
>>> I still see the following commit in rc2 ...
>>>
>>> commit bb52152abe85f971278a7a4f033b29483f64bfdb
>>> Author: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
>>> Date: Thu Jun 13 23:59:45 2019 +0200
>>>
>>> PCI: PM: Skip devices in D0 for suspend-to-idle
>
> Yes, I did not change anything in -rc2 for you, sorry.
>
>>> BTW, I checked the 4.14. queue and I do not see the above change in
>>> there, however, there is similar change ...
>>>
>>> Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
>>> PCI: PM: Avoid possible suspend-to-idle issue
>>>
>> bb52152abe85 fixes this one, which in turn fixes 33e4f80ee69b.
>> The above in 4.14 but not its fixes is spelling a bit of trouble.
>>
>> Maybe commit 471a739a47aa7 ("PCI: PM: Avoid skipping bus-level
>> PM on platforms without ACPI") was added to -rc2, since it is
>> supposed to fix bb52152abe85.
>
> I have added that fix to 4.14 now, and will go push out a -rc3 for both
> 4.19.y and 4.14.y to try to sync up on this and figure it out.
>
> Jon, if you could retest 4.14.y, that would be great, to see if it has
> the same issue that 4.19.y has. And if so, that means I should probably
> just drop both patches from both trees, right?


So v4.19 is still failing for me ...

Test results for stable-v4.19:
11 builds: 11 pass, 0 fail
22 boots: 22 pass, 0 fail
32 tests: 30 pass, 2 fail

Linux version: 4.19.99-rc3-g041f280e6a1a
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,
tegra194-p2972-0000, tegra20-ventana,
tegra210-p2371-2180, tegra30-cardhu-a04

However, I am not seeing any issues with v4.14, so still not clear what
is going on here.

Cheers
Jon

--
nvpublic