Re: [PATCH] net: cxgb3_main: Add CAP_NET_ADMIN check to CHELSIO_GET_MEM

[Michael Ellerman]

Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> writes:
> Hello!
>
> On 24.01.2020 12:41, Michael Ellerman wrote:
>
>> The cxgb3 driver for "Chelsio T3-based gigabit and 10Gb Ethernet
>> adapters" implements a custom ioctl as SIOCCHIOCTL/SIOCDEVPRIVATE in
>> cxgb_extension_ioctl().
>> 
>> One of the subcommands of the ioctl is CHELSIO_GET_MEM, which appears
>> to read memory directly out of the adapter and return it to userspace.
>> It's not entirely clear what the contents of the adapter memory
>> contains, but the assumption is that it shouldn't be accessible to all
>
>     s/contains/is/? Else it sounds tautological. :-)

Yeah you're right that would have been clearer.

Dave beat me to it and has already applied it, but thanks for reviewing
it anyway.

cheers