Re: Re: [PATCH v2 1/9] mm: Introduce Data Access MONitor (DAMON)

[sjpark]

On Tue, 28 Jan 2020 08:06:38 -0800 Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:

> On 1/28/20 12:57 AM, sjpark@xxxxxxxxxx wrote:
> > diff --git a/mm/Kconfig b/mm/Kconfig
> > index ab80933be65f..144fb916aa8b 100644
> > --- a/mm/Kconfig
> > +++ b/mm/Kconfig
> > @@ -739,4 +739,16 @@ config ARCH_HAS_HUGEPD
> >  config MAPPING_DIRTY_HELPERS
> >          bool
> >  
> > +config DAMON
> > +	tristate "Data Access Monitor"
> > +	depends on MMU
> > +	default y
> 
> Might be lightweight but still should not default to 'y'.

Good point, will default to 'n' in next spin.


Thanks,
SeongJae Park

> 
> > +	help
> > +	  Provides data access monitoring.
> > +
> > +	  DAMON is a kernel module that allows users to monitor the actual
> > +	  memory access pattern of specific user-space processes.  It aims to
> > +	  be 1) accurate enough to be useful for performance-centric domains,
> > +	  and 2) sufficiently light-weight so that it can be applied online.
> > +
> >  endmenu
> 
> thanks.
> -- 
> ~Randy
>