Re: [PATCH RFC 0/2] Add basic generic ACPI soc driver

From: John Garry
Date: Tue Jan 28 2020 - 12:28:37 EST

On 28/01/2020 16:56, Jeremy Linton wrote:

Hi Jeremy,

On 1/28/20 5:14 AM, John Garry wrote:
A requirement has come up recently to be able to read system SoC packages
identifiers from userspace [0].

For device tree FW-based systems, this would be quite straightforward, in
that we could add a soc driver for that system and use the DT model
identifier as the soc id - that's how most soc drivers seem to do it.

For ACPI-based systems, the only place I know to get (put) such SoC
information is in the PPTT, specifically the ID Type Structure for a
processor package node. A processor package node describes a physical
boundary of a processor topology.

Well presumably that is one of the use cases for DMI, which has fields for the processor/socket as well as the machine vendor.

I did consider DMI, but I want something more generic, i.e. could cover embedded/DT systems also.

And I need to double check if DMI really has the info I require. Last time I checked, it didn't for my dev board, but I know that some fields are simply not filled in.

But, quickly looking at the use case, I can't help but think you don't really want any of the above, or the PPTT id. It seems the mapping should actually be tied directly to the uncore PMU definition, rather than a soc/machine/whatever identifier. Which would imply keying off one of the ACPI object identifiers for the PMU itself.

So a PMU device (/sys/bus/event_source/devices) does not have a link to the ACPI object identifiers or uncore PMU platform device etc.

And even if it did, there is no clear link between that ACPI object and the events it supports for that implementation.


The ACPI spec does not declare how the fields in this structure must be
used, however it does provide pretty clear examples, which I would expect
most implementers to follow. As such, I try to solve the problem in 2
- Add ACPI PPTT API to get opaque package structure
- Add basic ACPI generic soc driver, which can interpret the fields
ÂÂ for known platforms to fill in the ID Type Structure as per example
ÂÂ in the spec.

So I'm hoping here for some comments on this approach - hence the RFC.
I've cc'ed some folks which may have suggestions.

[0] ,

John Garry (2):
ÂÂ ACPI/PPTT: Add acpi_pptt_get_package_info() API
ÂÂ soc: Add a basic ACPI generic driver

 drivers/acpi/pptt.c | 81 +++++++++++++++++++++++++++++
 drivers/soc/Makefile | 1 +
 drivers/soc/acpi_generic.c | 102 +++++++++++++++++++++++++++++++++++++
 include/linux/acpi.h | 13 +++++
 4 files changed, 197 insertions(+)
 create mode 100644 drivers/soc/acpi_generic.c