Re: [PATCH] mptcp: MPTCP_HMAC_TEST should depend on MPTCP

From: Mat Martineau
Date: Wed Jan 29 2020 - 16:08:09 EST



On Wed, 29 Jan 2020, Geert Uytterhoeven wrote:

As the MPTCP HMAC test is integrated into the MPTCP code, it can be
built only when MPTCP is enabled. Hence when MPTCP is disabled, asking
the user if the test code should be enabled is futile.

Wrap the whole block of MPTCP-specific config options inside a check for
MPTCP. While at it, drop the "default n" for MPTCP_HMAC_TEST, as that
is the default anyway.

Fixes: 65492c5a6ab5df50 ("mptcp: move from sha1 (v0) to sha256 (v1)")
Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
---

Reviewed-by: Mat Martineau <mathew.j.martineau@xxxxxxxxxxxxxxx>

--
Mat Martineau
Intel