Re: [PATCH v2] PCI/MSI: Avoid torn updates to MSI pairs

From: Thomas Gleixner
Date: Wed Jan 29 2020 - 18:16:43 EST


Evan,

Evan Green <evgreen@xxxxxxxxxxxx> writes:
> On Wed, Jan 29, 2020 at 1:01 PM Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
>
>> Could you please add some instrumentation to see how often this stuff
>> actually triggers spurious interrupts?
>
> In about 10 minutes of this script running, I got 142 hits. My script
> can toggle the HT cpus on and off about twice per second.
> Here's my diff (sorry it's mangled by gmail). If you're looking for
> something else, let me know, or I can run a patch.
>
No, that's good data. Your testing is hiting the critical path and as
you did not complain about negative side effects it seems to hold up to
the expectations. I'm going to convert this to real patch with a
proper changelog tomorrow.

Thanks for your help!

tglx