Re: [PATCH v5 0/4] perf: Refactor the block info implementation

[Jiri Olsa]

On Tue, Jan 28, 2020 at 08:55:52PM +0800, Jin Yao wrote:
> This patch series refactors the block info functionalities to let them
> be used by other builtins and allow setting the output fmts flexibly.
> 
> It also supports the 'Sampled Cycles%' and 'Avg Cycles%' printed in
> colors.
> 
>  v5:
>  ---
>  Only change the patch "perf util: Flexible to set block info output formats".
>  Other patches are not changed.
> 
> Jin Yao (4):
>   perf util: Move block_pair_cmp to block-info
>   perf util: Validate map/dso/sym before comparing blocks
>   perf util: Flexible to set block info output formats
>   perf util: Support color ops to print block percents in color

Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>

thanks,
jirka

> 
>  tools/perf/builtin-diff.c    | 17 -------
>  tools/perf/builtin-report.c  | 21 ++++++--
>  tools/perf/util/block-info.c | 99 ++++++++++++++++++++++++++----------
>  tools/perf/util/block-info.h |  9 +++-
>  4 files changed, 99 insertions(+), 47 deletions(-)
> 
> -- 
> 2.17.1
>