Re: [GIT PULL] x86/asm changes for v5.6

From: Borislav Petkov
Date: Thu Jan 30 2020 - 12:39:18 EST


On Thu, Jan 30, 2020 at 07:27:28AM -0800, Linus Torvalds wrote:
> Fair enough. Let's not complicate things just to avoid a few nops.

Yeah, judging by the frequency this keeps popping up, we might end up
doing proper insn parsing for the alternatives soon. :)

> That does make me wonder about RIP-relative addressing in alternatives
> too. Particularly anything where we let gcc pick addressing modes. I
> guess we don't have any, but maybe this branch issue and possible RIP
> addressing is something that objtool could be taught to warn about?

Yeah, makes sense. It would help if one slaps a relative JMP as *not*
the first insn in an alternatives replacement and the build to warn that
it can't work. Lemme go stare at objtool.

--
Regards/Gruss,
Boris.

SUSE Software Solutions Germany GmbH, GF: Felix ImendÃrffer, HRB 36809, AG NÃrnberg