Re: [PATCH ghak25 v2 1/9] netfilter: normalize x_table function declarations

From: Paul Moore
Date: Thu Jan 30 2020 - 22:17:53 EST


On Mon, Jan 6, 2020 at 1:54 PM Richard Guy Briggs <rgb@xxxxxxxxxx> wrote:
> Git context diffs were being produced with unhelpful declaration types
> in the place of function names to help identify the funciton in which
^^^^^^^^
function
> changes were made.
>
> Normalize x_table function declarations so that git context diff
> function labels work as expected.
>
> Signed-off-by: Richard Guy Briggs <rgb@xxxxxxxxxx>
> ---
> net/netfilter/x_tables.c | 43 ++++++++++++++++++-------------------------
> 1 file changed, 18 insertions(+), 25 deletions(-)

Considering that this patch is a style change in code outside of
audit, and we want to merge this via the audit tree, I think it is
best if you drop the style changes from this patchset. You can always
submit them later to the netfilter developers.

--
paul moore
www.paul-moore.com