Re: [PATCH v3 -next 3/4] net: emaclite: Fix arm64 compilation warnings

From: Andrew Lunn
Date: Fri Jan 31 2020 - 08:37:50 EST


On Fri, Jan 31, 2020 at 05:17:49PM +0530, Radhey Shyam Pandey wrote:
>
> /* BUFFER_ALIGN(adr) calculates the number of bytes to the next alignment. */
> -#define BUFFER_ALIGN(adr) ((ALIGNMENT - ((u32)adr)) % ALIGNMENT)
> +#define BUFFER_ALIGN(adr) ((ALIGNMENT - ((ulong)adr)) % ALIGNMENT)

Hi Radhey

linux/kernel.h has a few interesting macros, like

#define ALIGN(x, a) __ALIGN_KERNEL((x), (a))

These are more likely to be correct across all architectures than
anything you role yourself.

Andrew