Re: [PATCH v6 0/5] usb: xhci: Add support for Renesas USB controllers

From: Alan Stern
Date: Fri Jan 31 2020 - 10:47:30 EST


On Thu, 30 Jan 2020, Mathias Nyman wrote:

> I realize this can't be easily changed because usb_hcd_pci_probe() takes the
> pci_device_id pointer as an argument, and expects id.driver_data to be a
> HC driver pointer.
>
> So this turns out to be a question for Greg and Alan:
>
> Would it make sense to change usb_hcd_pci_probe() to take a HC driver pointer
> as an argument instead of a pointer to pci_device_id?
> pci_device_id pointer is only used to extract the HC driver handle.
> This way the driver_data could be used for, well, driver data.

That seems like a good idea to me. There aren't very many drivers that
use usb_hcd_pci_probe(); changing them all should be fairly easy.

Alan Stern