Re: [PATCH -v2 00/10] Rewrite Motorola MMU page-table layout

[Greg Ungerer]

Hi Peter,

On 31/1/20 11:19 pm, Greg Ungerer wrote:
> On 31/1/20 10:45 pm, Peter Zijlstra wrote:
> > In order to faciliate Will's READ_ONCE() patches:
> >
> > ÂÂ https://lkml.kernel.org/r/20200123153341.19947-1-will@xxxxxxxxxx
> >
> > we need to fix m68k/motorola to not have a giant pmd_t. These patches do so and
> > are tested using ARAnyM/68040.
> >
> > Michael tested the previous version on his Atari Falcon/68030.
> >
> > Build tested for sun3/coldfire.
>
> Thanks for the quick turn around. Build looks good for me too with
> this new series. I will test on real hardware on Monday.

So this tests good for me on real hardware. I had a look over the
ColdFire changes and I have no problems with anything.
So for the ColdFire parts:

Tested-by: Greg Ungerer <gerg@xxxxxxxxxxxxxx>
Acked-by: Greg Ungerer <gerg@xxxxxxxxxxxxxx>

Regards
Greg


> > Please consider!
> >
> > Changes since -v1:
> > Â - fixed sun3/coldfire build issues
> > Â - unified motorola mmu page setup
> > Â - added enum to table allocator
> > Â - moved pointer table allocator to motorola.c
> > Â - converted coldfire pgtable_t
> > Â - fixed coldfire pgd_alloc
> > Â - fixed coldfire nocache
> >
> > ---
> > Â arch/m68k/include/asm/mcf_pgalloc.hÂÂÂÂÂ |Â 31 ++---
> > Â arch/m68k/include/asm/motorola_pgalloc.h |Â 74 ++++------
> > Â arch/m68k/include/asm/motorola_pgtable.h |Â 36 +++--
> > Â arch/m68k/include/asm/page.hÂÂÂÂÂÂÂÂÂÂÂÂ |Â 16 ++-
> > Â arch/m68k/include/asm/pgtable_mm.hÂÂÂÂÂÂ |Â 10 +-
> > Â arch/m68k/mm/init.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |Â 34 +++--
> > Â arch/m68k/mm/kmap.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ |Â 36 +++--
> > Â arch/m68k/mm/memory.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ | 103 --------------
> > Â arch/m68k/mm/motorola.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ | 228 +++++++++++++++++++++++++------
> > Â 9 files changed, 302 insertions(+), 266 deletions(-)