Re: [PATCH -next] nfsd: make nfsd_filecache_wq variable static

From: J. Bruce Fields
Date: Tue Feb 04 2020 - 11:40:55 EST


Thanks, applying.--b.

On Mon, Feb 03, 2020 at 09:43:57AM +0800, Chen Zhou wrote:
> Fix sparse warning:
>
> fs/nfsd/filecache.c:55:25: warning:
> symbol 'nfsd_filecache_wq' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Chen Zhou <chenzhou10@xxxxxxxxxx>
> ---
> fs/nfsd/filecache.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/filecache.c b/fs/nfsd/filecache.c
> index 23c1fa5..22e77ed 100644
> --- a/fs/nfsd/filecache.c
> +++ b/fs/nfsd/filecache.c
> @@ -52,7 +52,7 @@ struct nfsd_fcache_disposal {
> struct rcu_head rcu;
> };
>
> -struct workqueue_struct *nfsd_filecache_wq __read_mostly;
> +static struct workqueue_struct *nfsd_filecache_wq __read_mostly;
>
> static struct kmem_cache *nfsd_file_slab;
> static struct kmem_cache *nfsd_file_mark_slab;
> --
> 2.7.4