Re: [PATCH 1/3] i2c: qcom-geni: Let firmware specify irq trigger flags

From: Brendan Higgins
Date: Tue Feb 04 2020 - 16:06:12 EST


On Tue, Feb 4, 2020 at 11:32 AM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote:
>
> We don't need to force IRQF_TRIGGER_HIGH here as the DT or ACPI tables
> should take care of this for us. Just use 0 instead so that we use the
> flags from the firmware. Also, remove specify dev_name() for the irq
> name so that we can get better information in /proc/interrupts about
> which device is generating interrupts.
>
> Cc: Girish Mahadevan <girishm@xxxxxxxxxxxxxx>
> Cc: Dilip Kota <dkota@xxxxxxxxxxxxxx>
> Cc: Alok Chauhan <alokc@xxxxxxxxxxxxxx>
> Cc: Douglas Anderson <dianders@xxxxxxxxxxxx>
> Signed-off-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>

Reviewed-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx>

Seems pretty straightforward to me.